Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable HIDE_SYMBOLS_BY_DEFAULT #549

Closed
wants to merge 2 commits into from
Closed

Enable HIDE_SYMBOLS_BY_DEFAULT #549

wants to merge 2 commits into from

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Nov 6, 2023

🎉 New feature

Closes #

Summary

Use the hidden visibility by default in preparation to make the change generally on Ionic using Part of gazebosim/gz-cmake#166

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@j-rivero
Enable HIDE_SYMBOLS_BY_DEFAULT
f18d2ba 
Signed-off-by: Jose Luis Rivero <[email protected]>
mjcarroll
mjcarroll approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #549 (767be55) into main (57b6f81) will not change coverage.
The diff coverage is n/a.

❗ Current head 767be55 differs from pull request most recent head 41999c9. Consider uploading reports for the commit 41999c9 to get more accurate results

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          79       79           
  Lines       10213    10213           
=======================================
  Hits         8542     8542           
  Misses       1671     1671

see 1 file with indirect coverage changes

@j-rivero
Copy link
Contributor Author

j-rivero commented Nov 7, 2023

Failing probably because of this #548 (comment) . I'm fixing it first.

@scpeters scpeters mentioned this pull request Nov 9, 2023
Closed
9 tasks
@scpeters scpeters mentioned this pull request Nov 9, 2023
Merged
8 tasks
@mjcarroll
Copy link
Contributor

Included in #550

@mjcarroll mjcarroll closed this Nov 10, 2023
@mjcarroll mjcarroll deleted the jrivero/hidden_symbols branch November 10, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@marcoag marcoag Awaiting requested review from marcoag marcoag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @mjcarroll @scpeters